Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove omitempty for Embeds #1106

Merged
merged 2 commits into from Mar 7, 2022
Merged

Remove omitempty for Embeds #1106

merged 2 commits into from Mar 7, 2022

Conversation

fiatjaf
Copy link
Contributor

@fiatjaf fiatjaf commented Feb 24, 2022

@FedorLap2006 FedorLap2006 added the breaking changes Contains breaking changes. Should be reflected in the changelog label Feb 27, 2022
@fiatjaf
Copy link
Contributor Author

fiatjaf commented Feb 28, 2022

Added a new commit to allow TextInputs to have required: false, otherwise they're assumed as required by Discord.

@FedorLap2006
Copy link
Collaborator

Added a new commit to allow TextInputs to have required: false, otherwise they're assumed as required by Discord.

Good catch! I totally overlooked this.
Sorry that review took a long time.

@FedorLap2006 FedorLap2006 changed the title do not omit empty .Embeds so we can clear embeds when editing Remove omitempty for Embeds Mar 7, 2022
@FedorLap2006 FedorLap2006 merged commit 9586f7f into bwmarrin:master Mar 7, 2022
@fiatjaf fiatjaf deleted the do-not-omit-empty-embeds branch March 7, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking changes Contains breaking changes. Should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fiatjaf @FedorLap2006