Add Invite Create/Delete #1105
Merged
Add Invite Create/Delete #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelrazor
commented
Feb 24, 2022
FedorLap2006
requested changes
Feb 25, 2022
message.go
Outdated
Comment on lines
437
to
438
| // This is used instead of Application to reduce the amount of memory consumption | ||
| // of message objects |
There was a problem hiding this comment.
I'm not sure if this PR would be right place to add this comment
structs.go
Outdated
Comment on lines
152
to
154
| // TODO: Remove this when compatibility is not required | ||
| // Deprecated | ||
| RedirectURIs *[]string `json:"-"` |
There was a problem hiding this comment.
Better to remove this field, since it doesn't have a purpose anymore.
structs.go
Outdated
Comment on lines
252
to
261
| // TargetUserType is the type of the target user | ||
| // https://discord.com/developers/docs/resources/invite#invite-object-target-user-types | ||
| // TODO: Remove this when compatibility is not required | ||
| // Deprecated: see InviteTargetType | ||
| type TargetUserType int | ||
|
|
||
| // Block contains known TargetUserType values | ||
| // Deprecated: see InviteTargetType | ||
| const ( | ||
| TargetUserTypeStream TargetUserType = 1 | ||
| ) |
There was a problem hiding this comment.
Since the type is meant to be renamed I think it would be fair to remove the old one.
FedorLap2006
approved these changes
Feb 25, 2022
|
Thanks for the contribution! |
FedorLap2006
added
the
breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104
See this PR and the linked one for the change of target_user_type -> target_type
I moved the Application struct, and i noticed that there were some fields not on the discord documentation, nor in the git history of the docs repo. Does the oauth2/applications/ endpoint still exist? all i can find is this.