Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping user account endpoints and functionality #1087

Merged
merged 6 commits into from Feb 15, 2022

Conversation

FedorLap2006
Copy link
Collaborator

@FedorLap2006 FedorLap2006 commented Feb 8, 2022

This PR drops all user account related functionality and endpoints.
Due to the fact it violates Discord ToS and due to recent changes in rules for Discord Developers Rommunity Resources it needs to be dropped.

discord.go Outdated Show resolved Hide resolved
This commit drops old email/password authentication for New function.
It violates Discord ToS and due to recent changes in rules for community resources on Discord API Docs it needs to be dropped.
@bwmarrin bwmarrin added the feedback Additional feedback is required label Feb 8, 2022
@bwmarrin
Copy link
Owner

bwmarrin commented Feb 8, 2022

I'm inclined to go forward to dropping user account exclusive code - but I'm open to discussion here and thoughts from anyone that thinks this will cause them any issues. So we'll leave this open for a few days at least to allow for that.

Along with time for others to review the change for issues/bugs/etc.

@FedorLap2006
Copy link
Collaborator Author

Should be all good now!

@FedorLap2006 FedorLap2006 merged commit 6fe303c into bwmarrin:master Feb 15, 2022
@FedorLap2006 FedorLap2006 added this to the v0.24.0 milestone Feb 27, 2022
@FedorLap2006 FedorLap2006 added the breaking changes Contains breaking changes. Should be reflected in the changelog label Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Contains breaking changes. Should be reflected in the changelog feedback Additional feedback is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants