fix shadowed variables that were preventing errors from being returned properly #1030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled latest and opened it up in VS Code, and there were 3
ineffectual assignment to err (ineffassign)
errors from thego-golangci-lint
linter, found inrestapi.go
on line 2548,state.go
on line 857, andstate.go
on line 873.The "ineffectual assignment to err" means that the code is assigning a value to a variable
err
, but then the variable goes out of scope without ever being used. Looking at the code, all 3 cases are due to the:=
assignment operator creating a seconderr
variable in the local scope, instead of re-using theerr
that is a named return value.More info: Golang Variable Shadowing.