Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks API isn't complete. #951

Closed
FedorLap2006 opened this issue Jun 15, 2021 · 3 comments
Closed

Webhooks API isn't complete. #951

FedorLap2006 opened this issue Jun 15, 2021 · 3 comments

Comments

@FedorLap2006
Copy link
Collaborator

When I was reading the Discord API docs as usual... while making #933 I found that our current API is missing the one endpoint. And these endpoints: webhook execute, webhook message edit and message delete lack support of attachments. And in case of webhook message edit endpoint - it's also missing returned by the endpoint message object (updated message).

P.S. Basically I have the code to fix these issue, but would like to know, open another PR on that, or include it straight into #933?

@FedorLap2006
Copy link
Collaborator Author

Since no one wants to respond, I will probably include them in the next PR.

@jolheiser
Copy link
Contributor

I would argue that webhook changes should go in a separate PR unless they are added specifically for the interactions.

e.g. attachment support could probably go in another PR

@FedorLap2006
Copy link
Collaborator Author

FedorLap2006 commented Jun 18, 2021

Well, late. Already pushed this to #954. Can remove the code from there tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants