Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimit for FollowupMessageCreate #1333

Open
FedorLap2006 opened this issue Feb 20, 2023 Discussed in #1332 · 3 comments · May be fixed by #1354
Open

RateLimit for FollowupMessageCreate #1333

FedorLap2006 opened this issue Feb 20, 2023 Discussed in #1332 · 3 comments · May be fixed by #1354

Comments

@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Feb 20, 2023 •
edited

Every interaction has unique token, therefore a call of FollowupMessageCreate will create a bucket per interaction.
This might cause the bot to OOM eventually.

Originally posted by @wu56781234 in #1332
@wu56781234
Copy link

@FedorLap2006 Do we need bucket for FollowupMessageCreate？ Discord API says Create Followup Message are not bound to Application Global Rate Limit.
https://discord.com/developers/docs/interactions/receiving-and-responding#endpoints

wu56781234 pushed a commit to wu56781234/discordgo that referenced this issue Feb 21, 2023
Fixed bwmarrin#1333.
4bda157
wu56781234 pushed a commit to wu56781234/discordgo that referenced this issue Feb 22, 2023
Since FollowupMessageCreate doesn't bound to global rate limit, use R…
8032d03 
…equestWithoutBucket instead.

Try to fix bwmarrin#1333
@wu56781234
Copy link

@FedorLap2006 @bwmarrin regarding this issue, can i submit a merge request?

@wu56781234
Copy link

And also I noticed that current buckets keep growing. To solve this can implement a schedule intervally remove those expired buckets.

@wu56781234 wu56781234 linked a pull request Mar 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/ratelimiter wu56781234/discordgo
2 participants
@wu56781234 @FedorLap2006