Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting bool fields of ChannelEdit to false #1199

Merged
merged 1 commit into from Jul 29, 2022

Conversation

iokill
Copy link
Contributor

@iokill iokill commented Jun 18, 2022

Setting e.g. ChannelEdit.Archived = false is currently not possible as Go will treat a false value as empty and will omit the archived property from the resulting JSON object. The same goes for Locked, NSFW and Invitable.

structs.go Outdated Show resolved Hide resolved
@iokill iokill changed the title Support unarchiving threads Allow setting bool properties of ChannelEdit to false Jun 18, 2022
@FedorLap2006 FedorLap2006 changed the title Allow setting bool properties of ChannelEdit to false Make bool fields in ChannelEdit pointers Jun 19, 2022
@FedorLap2006 FedorLap2006 changed the title Make bool fields in ChannelEdit pointers Allow setting bool fields of ChannelEdit to false Jun 19, 2022
@FedorLap2006
Copy link
Collaborator

Please note the checks.

Setting e.g. ChannelEdit.Archived = false is currently not possible
as go will treat a false as empty and will omit the property
from the JSON object.
@FedorLap2006 FedorLap2006 added the breaking changes Contains breaking changes. Should be reflected in the changelog label Jun 22, 2022
@FedorLap2006 FedorLap2006 added high priority Issue or PR with high priority of merge fix Pull requests and issues related to bug fixes and structural inconsistencies labels Jul 9, 2022
@FedorLap2006 FedorLap2006 merged commit 8b18bf4 into bwmarrin:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Contains breaking changes. Should be reflected in the changelog fix Pull requests and issues related to bug fixes and structural inconsistencies high priority Issue or PR with high priority of merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants