Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for with_localizations flag #1196

Merged
merged 4 commits into from Jun 19, 2022
Merged

Add support for with_localizations flag #1196

merged 4 commits into from Jun 19, 2022

Conversation

EliasStar
Copy link
Contributor

@EliasStar EliasStar commented Jun 7, 2022 •
edited

Fixes #1195

FedorLap2006
FedorLap2006 requested changes Jun 7, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
interactions.go Outdated Show resolved Hide resolved
@FedorLap2006 FedorLap2006 added feature Feature implementation feedback Additional feedback is required breaking changes Contains breaking changes. Should be reflected in the changelog help wanted Requires additional help labels Jun 7, 2022
@EliasStar
Improve support for application command localizations
ee4dacd 
Signed-off-by: GitHub <noreply@github.com>
@EliasStar
Copy link
Contributor Author

EliasStar commented Jun 9, 2022 •
edited

Implemented your suggestions @FedorLap2006. Ready to merge!

FedorLap2006
FedorLap2006 requested changes Jun 11, 2022
View reviewed changes
restapi.go Outdated Show resolved Hide resolved
@EliasStar @FedorLap2006
Remove query string from bucket name
cde17c5 
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@FedorLap2006
Copy link
Collaborator

Please note the checks.

@EliasStar
Copy link
Contributor Author

Please approve the workflow once again.

@EliasStar
Copy link
Contributor Author

EliasStar commented Jun 18, 2022 •
edited

I would appreciate if we could merge this, so I can retarget my bot to this repo away from the fork. Also this pull request doesn't contain breaking changes anymore.

@FedorLap2006 FedorLap2006 removed help wanted Requires additional help feedback Additional feedback is required breaking changes Contains breaking changes. Should be reflected in the changelog labels Jun 18, 2022
@FedorLap2006 FedorLap2006 merged commit a7b7eaa into bwmarrin:master Jun 19, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedorLap2006 FedorLap2006 FedorLap2006 approved these changes

Assignees
No one assigned
Labels
feature Feature implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support with_localizations query string for Get Application Commands endpoints
2 participants
@EliasStar @FedorLap2006