Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dialer property to Session #1179

Merged
merged 1 commit into from Aug 13, 2022
Merged

Add Dialer property to Session #1179

merged 1 commit into from Aug 13, 2022

Conversation

uWynell
Copy link
Contributor

@uWynell uWynell commented May 6, 2022

A little attempt to make this pull request.
Why would I need such an update? For example, if I would be able to pass custom Dialer, then I could use proxy (click).

dialSocksProxy, _:= proxy.SOCKS5("tcp", "proxy_ip", nil, proxy.Direct)
s, _:= discordgo.New("token")
s.Dialer = &websocket.Dialer{Dial: dialSocksProxy.Dial}

Sorry if I'm wrong. I'll be very happy to hear where exactly I made a mistake, if there's one.

@FedorLap2006 FedorLap2006 changed the title Add dialer property in config Add Dialer property to Session May 10, 2022
@FedorLap2006 FedorLap2006 force-pushed the master branch 2 times, most recently from 05d8167 to d7b4a48 Compare May 22, 2022 22:16
@FedorLap2006 FedorLap2006 added the feature Feature implementation label May 23, 2022
@FedorLap2006 FedorLap2006 self-requested a review July 9, 2022 15:16
@FedorLap2006 FedorLap2006 self-assigned this Jul 9, 2022
@FedorLap2006 FedorLap2006 added the feedback Additional feedback is required label Jul 9, 2022
structs.go Show resolved Hide resolved
@FedorLap2006 FedorLap2006 added this to the v0.26.0 milestone Aug 4, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for the contribution!

P.S. While ideally the voice (see the comment above) related changes should have been implemented here, I'll be adding them in a separate PR, since you have disabled maintainer edits on the branch.

@FedorLap2006 FedorLap2006 merged commit 262e8ba into bwmarrin:master Aug 13, 2022
@uWynell
Copy link
Contributor Author

uWynell commented Aug 13, 2022

Sorry for my inactivity, I hadn't even logged into my account since this PR.

@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Aug 13, 2022

No problem. Additionally, as you can see, I've adressed it in the PR mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature implementation feedback Additional feedback is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants