Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support of Stage Instance RestAPI and Events #1158

Merged
merged 15 commits into from Apr 14, 2022

Conversation

42atomys
Copy link
Contributor

Describe task
Add the support of Stage Instance to the discordgo library.

Notes
I also add the link between Stage Channel, Stage Instance and Scheduled Events

The RestAPI endpoint is not tested for the moment, the stage instance needs to have a stage channel setup and user presence in channel to be test

Resolves #903

@42atomys
Copy link
Contributor Author

@FedorLap2006 Ready for the review I think ^^

restapi.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
restapi.go Show resolved Hide resolved
restapi.go Show resolved Hide resolved
restapi.go Show resolved Hide resolved
@42atomys
Copy link
Contributor Author

I will push an example soon

Turn on Draft

@42atomys 42atomys marked this pull request as draft April 13, 2022 22:31
@42atomys 42atomys marked this pull request as ready for review April 13, 2022 22:57
structs.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
@FedorLap2006 FedorLap2006 mentioned this pull request Apr 14, 2022
@FedorLap2006 FedorLap2006 added this to the v0.25.0 milestone Apr 14, 2022
@FedorLap2006 FedorLap2006 added the high priority Issue or PR with high priority of merge label Apr 14, 2022
structs.go Outdated Show resolved Hide resolved
restapi.go Show resolved Hide resolved
restapi.go Show resolved Hide resolved
restapi.go Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
restapi.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
42atomys and others added 3 commits April 14, 2022 22:05
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
structs.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
42atomys and others added 2 commits April 14, 2022 22:28
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
@FedorLap2006 FedorLap2006 added the feature Feature implementation label Apr 14, 2022
Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think would be good to add timeouts (e.g. 5 seconds) between Edit and Delete operations in the example, so user can see the results for themselves.

@42atomys
Copy link
Contributor Author

Done

@FedorLap2006 FedorLap2006 merged commit 8a126aa into bwmarrin:master Apr 14, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature implementation high priority Issue or PR with high priority of merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stage channels
4 participants