Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RequestGuildMembers method and GuildMembersChunk event struct #1156

Merged
merged 5 commits into from Apr 15, 2022

Conversation

Pancake-e
Copy link
Contributor

I'm not sure if the "guild_id" field should be an array because according to the documentation, it should be a string. The endpoint accepts both array and string without errors.

wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
@FedorLap2006 FedorLap2006 added this to the v0.25.0 milestone Apr 14, 2022
events.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Outdated Show resolved Hide resolved
wsapi.go Show resolved Hide resolved
wsapi.go Show resolved Hide resolved
Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@FedorLap2006 FedorLap2006 merged commit 6f6516b into bwmarrin:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants