Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable rate-limited request retry #1151

Merged
merged 2 commits into from Apr 14, 2022

Conversation

njhanley
Copy link
Contributor

@njhanley njhanley commented Apr 9, 2022

Some requests are time sensitive and become stale if not completed quickly. It's better to let the library user choose how to handle a rate limit being exceeded in those cases. ShouldRetryOnRateLimit is a session option which disables automatic retry and instead returns an error the user can use to handle retry manually.

Closes #1011.

restapi.go Outdated Show resolved Hide resolved
restapi.go Show resolved Hide resolved
@FedorLap2006 FedorLap2006 added this to the v0.25.0 milestone Apr 14, 2022
@FedorLap2006 FedorLap2006 added the high priority Issue or PR with high priority of merge label Apr 14, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@FedorLap2006 FedorLap2006 merged commit c615fc7 into bwmarrin:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Issue or PR with high priority of merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable retrying of rate limited requests
2 participants