Add Guild Scheduled Event Support #1032

42atomys · 2021-11-20T16:11:05Z

Discord just released a new feature: Guild Scheduled Event

Today I will start to add all endpoints listed in the API Reference (https://discord.com/developers/docs/resources/guild-scheduled-event#guild-scheduled-event)

Following this issue : #1031

QPixel

You'll also have to update your entire branch with the current state of master. @FedorLap2006 any additional things I didn't catch?

scheduled_events.go

structs.go

scheduled_events.go

42atomys · 2022-02-18T09:00:16Z

@QPixel Ready to review & launch 🎉

FedorLap2006 · 2022-02-18T11:56:18Z

You'll also have to update your entire branch with the current state of master. @FedorLap2006 any additional things I didn't catch?

I'll give it a look later this day

42atomys · 2022-02-20T17:47:34Z

I'll give it a look later this day

Hi @FedorLap2006 , any news ?

FedorLap2006 · 2022-02-20T22:09:07Z

I'll give it a look later this day

Hi @FedorLap2006 , any news ?

Making a review currently. Also please note conflicts.

42atomys · 2022-02-21T02:30:20Z

Amazing conflicts spawn before each review, I'm dead !

42atomys · 2022-02-21T11:50:52Z

Done again !

FedorLap2006

Thank you for the contribution!

Overall PR looks good. Except some moments.

There is an obvious problem with tests. They cover a really small portion of endpoints behaviour (e.g. Update is untested with some parameters being set, unset).
I would recommend also making an example, because this looks like a fairly complex topic for a beginner, and it would give you ability to catch more errors and mistakes in the process.

Please also note my comments.

scheduled_events.go

scheduled_events_test.go

structs.go

scheduled_events.go

scheduled_events_test.go

structs.go

42atomys · 2022-02-22T20:10:20Z

@FedorLap2006 I switch to two separated structs and add an example in bonus !

FedorLap2006

Overall looks good to me, but has a couple of issues.

examples/scheduled_events/main.go

structs.go

… necessary

nullable_type.go

restapi.go

structs.go

FedorLap2006 · 2022-02-25T22:35:17Z

Also, please note the conflicts.

…overflow on marshall same type

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

structs.go

42atomys · 2022-02-27T14:09:39Z

@FedorLap2006 all tests run with success

FedorLap2006 · 2022-02-27T14:10:34Z

@FedorLap2006 all tests run with success

Alright. Yea, everything should be fine, but I still don't completely get why 1 and 1 are there. The purpose is make the test coverage 100% & make function always return len == 0?

discord_test.go

42atomys · 2022-02-27T14:17:49Z

I still don't completely get why 1 and 1 are there.

Actually with or without 1 and 1, this function on test suite will always return len == 0 because no users can register via the API. Second point, DiscordAPI don't crash with 1 on snowflake -1 or 0 or malformed snowflake will return error

The purpose is make the test coverage 100% & make function always return len == 0

Yes it is, but formulated differently: Up the coverage to 100% on this test that will always return len(users) == 0

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

structs.go

restapi.go

discord_test.go

FedorLap2006 · 2022-02-27T14:42:25Z

Sorry that the review took long, found some additional grammar mistakes.

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

42atomys · 2022-02-27T14:53:11Z

Sorry that the review took long, found some additional grammar mistakes.

Dont worry, it is appreciated, english is not my natal language, I try to learn it :)

FedorLap2006 · 2022-02-27T15:10:56Z

Oh good, I don't need to do that myself.

FedorLap2006 · 2022-02-27T15:22:10Z

I think everything looks good. Thanks for your contribution!

42atomys · 2022-02-27T15:37:20Z

Thanks for your time ! I will push more soon 😀

A follow is appreciate ❤️

42atomys added 2 commits November 20, 2021 16:58

Add Guild Scheduled Events support

2b3d018

Add missing Indents for Guild Scheduled Events

84aaa03

QPixel suggested changes Feb 18, 2022

View reviewed changes

42atomys added 5 commits February 18, 2022 09:21

Merge remote-tracking branch 'upstream/master'

677fcc2

fix: Do update from new schedules updates and repository updates

1bcc001

doc: Add missing documentation on const

6554e26

doc: Add missing documentation on events struct

260e8ca

tests: Add a Skip condition when dgBot is not set to prevent segfault

d7dc906

fix: Resolve merge conflicts

1359c13

FedorLap2006 requested changes Feb 22, 2022

View reviewed changes

FedorLap2006 reviewed Feb 22, 2022

View reviewed changes

structs.go Show resolved Hide resolved

42atomys added 2 commits February 22, 2022 21:08

fix: Somes changes following the last review steps

b08a6e3

docs: Add an example to manipulate GuildScheduledEvent

5fa6423

42atomys added 2 commits February 22, 2022 21:12

clean: Remove useless pointers on struct used to retrieve data

90751ec

tests: Test extra query params on GuildScheduledEventUsers requests

2aef679

FedorLap2006 requested changes Feb 22, 2022

View reviewed changes

examples/scheduled_events/main.go Outdated Show resolved Hide resolved

structs.go Show resolved Hide resolved

42atomys added 5 commits February 22, 2022 22:09

clean: Remove unused variables

78676f4

feat: Add nullable types to provide null value to Discord API when is…

ea5dc9a

… necessary

feat: Use NullableString in ScheduledEvents

4498cb6

docs: Add example for usage of NullableString

e02240e

Merge branch 'bwmarrin:master' into master

f5cac02

FedorLap2006 requested changes Feb 25, 2022

View reviewed changes

nullable_type.go Outdated Show resolved Hide resolved

restapi.go Outdated Show resolved Hide resolved

restapi.go Show resolved Hide resolved

restapi.go Outdated Show resolved Hide resolved

restapi.go Outdated Show resolved Hide resolved

structs.go Outdated Show resolved Hide resolved

42atomys and others added 5 commits February 27, 2022 14:55

fix: Rewrite Marshal of GuildScheduledEventParams to prevent a stack …

6b3074d

…overflow on marshall same type

clean: Remove unused Intents

5f37849

Update restapi.go

b289ecd

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

Update restapi.go

f82eff0

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

Update restapi.go

b542383

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

FedorLap2006 requested changes Feb 27, 2022

View reviewed changes

structs.go Outdated Show resolved Hide resolved

structs.go Outdated Show resolved Hide resolved

42atomys added 4 commits February 27, 2022 14:58

doc: polish the documentation

45008f8

Merge branch 'master' of github.com:42Atomys/discordgo

35ffaad

clean: Final polish code

0a42322

doc: Add information about 1:1 usage

35c4db9

FedorLap2006 reviewed Feb 27, 2022

View reviewed changes

discord_test.go Outdated Show resolved Hide resolved

FedorLap2006 reviewed Feb 27, 2022

View reviewed changes

discord_test.go Outdated Show resolved Hide resolved

42atomys and others added 2 commits February 27, 2022 15:18

Update discord_test.go

4e0be03

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

doc: remove unnecessary additional infos

204b188

FedorLap2006 requested changes Feb 27, 2022

View reviewed changes

structs.go Outdated Show resolved Hide resolved

restapi.go Outdated Show resolved Hide resolved

discord_test.go Outdated Show resolved Hide resolved

42atomys and others added 3 commits February 27, 2022 15:51

Update structs.go

2b67cfb

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

Update discord_test.go

675c43b

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

Update restapi.go

c1dc39a

Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>

FedorLap2006 and others added 3 commits February 27, 2022 18:03

chore(examples/scheduled_events): removed NullString comment

b62a67a

fix(structs): grammar in comment to EntityType

dcc7444

fix: run gofmt

a1e0044

FedorLap2006 merged commit 9448b0e into bwmarrin:master Feb 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Guild Scheduled Event Support #1032

Add Guild Scheduled Event Support #1032

42atomys commented Nov 20, 2021

QPixel left a comment

42atomys commented Feb 18, 2022

FedorLap2006 commented Feb 18, 2022

42atomys commented Feb 20, 2022 •

edited

FedorLap2006 commented Feb 20, 2022 •

edited

42atomys commented Feb 21, 2022

42atomys commented Feb 21, 2022

FedorLap2006 left a comment •

edited

42atomys commented Feb 22, 2022

FedorLap2006 left a comment

FedorLap2006 commented Feb 25, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

Add Guild Scheduled Event Support #1032

Add Guild Scheduled Event Support #1032

Conversation

42atomys commented Nov 20, 2021

QPixel left a comment

Choose a reason for hiding this comment

42atomys commented Feb 18, 2022

FedorLap2006 commented Feb 18, 2022

42atomys commented Feb 20, 2022 • edited

FedorLap2006 commented Feb 20, 2022 • edited

42atomys commented Feb 21, 2022

42atomys commented Feb 21, 2022

FedorLap2006 left a comment • edited

Choose a reason for hiding this comment

42atomys commented Feb 22, 2022

FedorLap2006 left a comment

Choose a reason for hiding this comment

FedorLap2006 commented Feb 25, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

FedorLap2006 commented Feb 27, 2022

42atomys commented Feb 27, 2022

42atomys commented Feb 20, 2022 •

edited

FedorLap2006 commented Feb 20, 2022 •

edited

FedorLap2006 left a comment •

edited