Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty to channel_id in MessageReference struct #1002

Merged
merged 1 commit into from Aug 4, 2022

Conversation

corbmr
Copy link
Contributor

@corbmr corbmr commented Sep 5, 2021

Per documentation channel_id and guild_id are not required. GuildID is already marked as omitempty but ChannelId can be as well.

@ayntee
Copy link

ayntee commented Sep 6, 2021

Screenshot_20210906_154602

@corbmr
Copy link
Contributor Author

corbmr commented Sep 6, 2021

omitempty only applies with encoding so I would think it should be considered optional for the sake of sending, not related to whichever fields are returned on receive.

@FedorLap2006 FedorLap2006 force-pushed the master branch 2 times, most recently from 05d8167 to d7b4a48 Compare May 22, 2022 22:16
@FedorLap2006 FedorLap2006 added the fix Pull requests and issues related to bug fixes and structural inconsistencies label May 23, 2022
@FedorLap2006 FedorLap2006 added this to the v0.26.0 milestone Aug 4, 2022
@FedorLap2006 FedorLap2006 self-assigned this Aug 4, 2022
@FedorLap2006 FedorLap2006 merged commit c0803d0 into bwmarrin:master Aug 4, 2022
@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

P.S. Sorry it took that long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests and issues related to bug fixes and structural inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants