From e24afd41c4eb39b949185e6e87687ee25df3991e Mon Sep 17 00:00:00 2001 From: Brendan Winter Date: Fri, 2 Jun 2023 14:13:09 -0700 Subject: [PATCH] Cleanup linting workflow actions. - Fix go lint version. - v3 of golint and remove the go-setup dependency: https://github.com/golangci/golangci-lint-action/pull/403 - Make the checkout step in the linter match the release config. - Good to be consistent so it's easier to tell your linting will pass release. Signed-off-by: Brendan Winter --- .github/workflows/golangci-lint.yml | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 8c9eda3..32c4786 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -1,17 +1,30 @@ name: golangci-lint + on: + push: + tags: + - v* + branches: + - master pull_request: + jobs: golangci: name: lint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - name: Checkout + uses: actions/checkout@v3 + with: + fetch-depth: 0 - name: golangci-lint - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: - version: v1.52.2 - skip-pkg-cache: true - skip-build-cache: true + # Required: the version of golangci-lint is required and must be specified without a patch version: + # we always use the latest patch version. + version: v1.52 + # Optional: if set to `true` then the all caching functionality will be complete disabled, + # takes precedence over all other caching options. + skip-cache: true args: --issues-exit-code=1 only-new-issues: true