Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dom-helpers@5.x #1421

Merged
merged 1 commit into from Oct 30, 2019
Merged

Upgrade to dom-helpers@5.x #1421

merged 1 commit into from Oct 30, 2019

Conversation

dominykas
Copy link
Contributor

@dominykas dominykas commented Sep 10, 2019

The breaking change was the dropped support of IE8 (not supported here) and a change in export layout: https://github.com/react-bootstrap/dom-helpers/blob/master/CHANGELOG.md#500-2019-08-30.

Depending on how you look at it, some may consider this upgrade to be a breaking change from this project's perspective (for those who are using older versions of dom-helpers, they may now have multiple versions in their bundles - old versions are incompatible with v5).

@codecov-io
Copy link

Codecov Report

Merging #1421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1421   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          59       59           
  Lines        1742     1742           
=======================================
  Hits         1574     1574           
  Misses        168      168
Impacted Files Coverage Δ
source/Collection/CollectionView.js 90.19% <ø> (ø) ⬆️
source/Grid/Grid.js 94.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a390b2a...daef4bd. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #1421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1421   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          59       59           
  Lines        1742     1742           
=======================================
  Hits         1574     1574           
  Misses        168      168
Impacted Files Coverage Δ
source/Collection/CollectionView.js 90.19% <ø> (ø) ⬆️
source/Grid/Grid.js 94.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a390b2a...daef4bd. Read the comment docs.

Copy link
Collaborator

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@wuweiweiwu wuweiweiwu merged commit 2ce867d into bvaughn:master Oct 30, 2019
@dominykas dominykas deleted the patch-1 branch October 30, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants