Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests that use try/catch around this.render #128

Closed
bantic opened this issue Mar 10, 2017 · 1 comment · Fixed by #129
Closed

fix tests that use try/catch around this.render #128

bantic opened this issue Mar 10, 2017 · 1 comment · Fixed by #129

Comments

@bantic
Copy link
Contributor

bantic commented Mar 10, 2017

In Ember 2.11, rendering in a test no longer throws an error, if one occurred during the rendering, so QUnit's assert.throws doesn't catch the error and the test that asserts rendering with no unknownCardHandler throws fails.
The code is still behaving as expected, but the tests need to be updated to correctly exercise this behavior for Ember versions >= 2.11.0
@bantic
Copy link
Contributor Author

bantic commented Mar 13, 2017

This was due to a change to make it so that the RSVP error handling and Backburner (runloop) error handling use a similar error dispatching mechanism. There's some discussion of how to fix that here:
emberjs/ember.js#14898

bantic added a commit that referenced this issue Mar 13, 2017
@bantic
Use TestAdapter to ensure render errors are thrown
dd69098 
Uses a customized test adapter for some tests that will rethrow errors
that occur during the render cycle. This fixes a few tests that were
false-negativing. Notes on the change to Ember are in emberjs/ember.js#14898

Fixes #128
@bantic bantic mentioned this issue Mar 13, 2017
Merged
bantic added a commit that referenced this issue Mar 13, 2017
@bantic
Use TestAdapter to ensure render errors are thrown (#129)
b830f52 
Uses a customized test adapter for some tests that will rethrow errors
that occur during the render cycle. This fixes a few tests that were
false-negativing. Notes on the change to Ember are in emberjs/ember.js#14898

Fixes #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use TestAdapter to ensure render errors are thrown bustle/ember-mobiledoc-editor
1 participant
@bantic