This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Fix bundler/inline warning: method redefined; discarding old root #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
fix-warnings
branch
from
96afe15
to
7952842
Compare
deivid-rodriguez
approved these changes
Nov 5, 2019
|
This was also the approach preferred by @segiddins to fix this, going in! @bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Nov 7, 2019
Build succeeded |
ghost
merged commit
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 7, 2019
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Nov 11, 2019
Features:
- Add caller information to some deprecation messages to make them easier to fix [#7361](rubygems/bundler#7361)
- Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](rubygems/bundler#7389)
- Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](rubygems/bundler#7394)
Bugfixes:
- Fix typos deprecation message and upgrading docs [#7374](rubygems/bundler#7374)
- Deprecation warnings about `taint` usage on ruby 2.7 [#7385](rubygems/bundler#7385)
- Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](rubygems/bundler#7388)
- `bundle add` should cache newly added gems if an application cache exists [#7393](rubygems/bundler#7393)
- Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](rubygems/bundler#7416)
- Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](rubygems/bundler#7417)
ghost
pushed a commit
that referenced
this pull request
Nov 12, 2019
7422: Turn on warning mode for specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we're missing verbose warnings like the one fixed by #7417. ### What was your diagnosis of the problem? My diagnosis was that our specs should let us know about this. ### What is your fix for the problem, implemented in this PR? My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green. ### Why did you choose this fix out of the possible options? I chose this fix because it makes it so that our specs help us catching these warnings earlier. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 13, 2019
7422: Turn on warning mode for specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that we're missing verbose warnings like the one fixed by #7417. ### What was your diagnosis of the problem? My diagnosis was that our specs should let us know about this. ### What is your fix for the problem, implemented in this PR? My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green. ### Why did you choose this fix out of the possible options? I chose this fix because it makes it so that our specs help us catching these warnings earlier. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 4244534)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6167