This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_help_with_command_aliases
branch
2 times, most recently
from
October 20, 2019 13:09
22e71b5
to
59290ac
Compare
To be consistent with the one above it.
Use a string when defining a single alias.
Since they were already consider aliases for `bundle help`.
When using the `-h` flag with command aliases, bundler was showing a default help page instead of our manual, so that for example, `bundle help install` and `bundle install --help` output would be inconstent with `bundle i --help`. This commit fixes that.
deivid-rodriguez
force-pushed
the
fix_help_with_command_aliases
branch
from
October 30, 2019 09:06
59290ac
to
e983b29
Compare
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Oct 30, 2019
7388: Fix help with command aliases r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the output of `bundle help install` and `bundle install --help` was inconstent with `bundle i --help`, and the same issue with all of the other command aliases. ### What was your diagnosis of the problem? My diagnosis was that the command reformatting so that `bundle <cmd> --help` "redirects" to `bundle help <cmd>` was ignoring command aliases. ### What is your fix for the problem, implemented in this PR? My fix is to make this logic aware of command aliases. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
deleted the
fix_help_with_command_aliases
branch
October 30, 2019 11:20
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 7, 2019
7388: Fix help with command aliases r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the output of `bundle help install` and `bundle install --help` was inconstent with `bundle i --help`, and the same issue with all of the other command aliases. ### What was your diagnosis of the problem? My diagnosis was that the command reformatting so that `bundle <cmd> --help` "redirects" to `bundle help <cmd>` was ignoring command aliases. ### What is your fix for the problem, implemented in this PR? My fix is to make this logic aware of command aliases. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 5bc9c58)
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Nov 11, 2019
Features: - Add caller information to some deprecation messages to make them easier to fix [#7361](rubygems/bundler#7361) - Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](rubygems/bundler#7389) - Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](rubygems/bundler#7394) Bugfixes: - Fix typos deprecation message and upgrading docs [#7374](rubygems/bundler#7374) - Deprecation warnings about `taint` usage on ruby 2.7 [#7385](rubygems/bundler#7385) - Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](rubygems/bundler#7388) - `bundle add` should cache newly added gems if an application cache exists [#7393](rubygems/bundler#7393) - Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](rubygems/bundler#7416) - Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](rubygems/bundler#7417)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that the output of
bundle help install
andbundle install --help
was inconstent withbundle i --help
, and the same issue with all of the other command aliases.What was your diagnosis of the problem?
My diagnosis was that the command reformatting so that
bundle <cmd> --help
"redirects" tobundle help <cmd>
was ignoring command aliases.What is your fix for the problem, implemented in this PR?
My fix is to make this logic aware of command aliases.