This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Gemspec require relative #7137
Merged
Gemspec require relative #7137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Going in! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 26, 2019
7137: Gemspec require relative r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? This is a follow up to #7100. Gemspec is another place where `require_relative` sounds like a win. ### What is your fix for the problem, implemented in this PR? My fix changes bundler's gemspec to use `require_relative`, and extracts the relevant change from #4397 to also change the generated gemspec from `bundle gem`. Co-authored-by: Miklos Fazekas <mfazekas@szemafor.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
This is a follow up to #7100. Gemspec is another place where
require_relativesounds like a win.What is your fix for the problem, implemented in this PR?
My fix changes bundler's gemspec to use
require_relative, and extracts the relevant change from #4397 to also change the generated gemspec frombundle gem.