This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Delegate should be supported now #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `did_you_mean` dropped its dependency on it.
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Dec 14, 2019
7483: Delegate should be supported now r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that delegate is now supported since `did_you_mean` drop its dependency on it at ruby/ruby@e270806. ### What was your diagnosis of the problem? My diagnosis was that we can test that arbitrary `delegate` versions can be included in Gemfiles again. ### What is your fix for the problem, implemented in this PR? My fix removes `delegate` from the exemptions. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 15, 2019
7483: Delegate should be supported now r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that delegate is now supported since `did_you_mean` drop its dependency on it at ruby/ruby@e270806. ### What was your diagnosis of the problem? My diagnosis was that we can test that arbitrary `delegate` versions can be included in Gemfiles again. ### What is your fix for the problem, implemented in this PR? My fix removes `delegate` from the exemptions. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit fc2b63c)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that delegate is now supported since
did_you_meandrop its dependency on it at ruby/ruby@e270806.What was your diagnosis of the problem?
My diagnosis was that we can test that arbitrary
delegateversions can be included in Gemfiles again.What is your fix for the problem, implemented in this PR?
My fix removes
delegatefrom the exemptions.