This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Fixed test failures with gem command path on ruby core repo #7482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deivid-rodriguez Can you backport this to |
|
Yes, I'll take care of it. |
|
Thanks! |
|
I confirmed to pass all tests of Bundler 2.1.0 with ruby master. https://github.com/ruby/ruby/pull/2753/checks?check_run_id=348617036 👍 |
deivid-rodriguez
force-pushed
the
fixed-bundler-specs-on-ruby-repo
branch
from
7d1a6fc
to
e1a6b5e
Compare
|
@hsbt One test failed in bundler, I tried to fix it. |
deivid-rodriguez
force-pushed
the
fixed-bundler-specs-on-ruby-repo
branch
from
e1a6b5e
to
f805835
Compare
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Dec 14, 2019
7482: Fixed test failures with gem command path on ruby core repo r=deivid-rodriguez a=hsbt ### What was the end-user problem that led to this PR? Some of the examples failed with ruby-core repository. ### What was your diagnosis of the problem? The ruby-core repository used `gem` commands under the its repository named `bin/gem` directory. But the current examples points `gem` command with a global path. ### What is your fix for the problem, implemented in this PR? I fixed them used by `ruby_core?` helper methods. Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org>
Build succeeded |
ghost
merged commit
|
@deivid-rodriguez Thanks! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 15, 2019
7482: Fixed test failures with gem command path on ruby core repo r=deivid-rodriguez a=hsbt ### What was the end-user problem that led to this PR? Some of the examples failed with ruby-core repository. ### What was your diagnosis of the problem? The ruby-core repository used `gem` commands under the its repository named `bin/gem` directory. But the current examples points `gem` command with a global path. ### What is your fix for the problem, implemented in this PR? I fixed them used by `ruby_core?` helper methods. Co-authored-by: Hiroshi SHIBATA <hsbt@ruby-lang.org> (cherry picked from commit 4045ba4)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Some of the examples failed with ruby-core repository.
What was your diagnosis of the problem?
The ruby-core repository used
gemcommands under the its repository namedbin/gemdirectory. But the current examples pointsgemcommand with a global path.What is your fix for the problem, implemented in this PR?
I fixed them used by
ruby_core?helper methods.