Support loading placeholders in compose previews #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composable placeholders already worked, but resource and drawable placeholders did not. Presumably some part of the production codepath isn't supported by the Android Studio renderer. The actual display of the resources seems to work fine, we just never get to that point in Glide's code. Debugging exactly what's happening seems mostly impossible. I don't see a way to view logs or debug code running in the Android Studio preview renderer. For now we can work around whatever the issue is by rendering resources and drawables when in preview mode earlier than normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composable placeholders already worked, but resource and drawable placeholders did not. Presumably some part of the production codepath isn't supported by the Android Studio renderer. The actual display of the resources seems to work fine, we just never get to that point in Glide's code. Debugging exactly what's happening seems mostly impossible. I don't see a way to view logs or debug code running in the Android Studio preview renderer.
For now we can work around whatever the issue is by rendering resources and drawables when in preview mode earlier than normal.