Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug within UlcerIndex feature #205

Closed
vinopm opened this issue Nov 16, 2020 · 1 comment
Closed

Bug within UlcerIndex feature #205

vinopm opened this issue Nov 16, 2020 · 1 comment

Comments

@vinopm
Copy link
Contributor

vinopm commented Nov 16, 2020 •
edited

Hi,

There is an issue with the newly introduced UlcerIndex feature.

Currently when calling the add_volatility_ta(df... function within wrapper.py, the DataFrame returned has a non numerical UlcerIndex column, where a reference to an UlcerIndex object exists within each row, instead of the correct float representation of the feature.

I have created a PR to ensure that the Ulcer Index feature values are returned in numerical representation within the DataFrame instead of as an UlcerIndex object.

Visual representation of the current issue:
image

Please review: #204 for the fix.

Many thanks!
@vinopm vinopm mentioned this issue Nov 17, 2020
Merged
@bukosabino
Copy link
Owner

Thanks for your work @vinopm ,

The fix has been included in a new version of the library (v0.6.1).

Best,
Dario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bukosabino @vinopm