Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions workflow for combo tests should use functionality in #550 #565

Closed
natalieparellano opened this issue Apr 7, 2020 · 2 comments
Closed

GitHub actions workflow for combo tests should use functionality in #550 #565

natalieparellano opened this issue Apr 7, 2020 · 2 comments
Assignees
@natalieparellano
Labels
size/md Medium level of effort type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

Description

We developed a mechanism for downloading the required assets for the combo tests, but it's not tested anywhere (though presumably, we will be using it).

Proposed solution

Use this mechanism in our GitHub actions workflow for the combo tests.

Describe alternatives you've considered

Do nothing. Assume we'd catch any issues in the course of our local development.

Additional context

We should still have 4 separate workflows, so that the suites could be run in parallel. We can specify the suite to run in ACCEPTANCE_SUITE_CONFIG.

This may require that we add GitHub authentication to GithubAssetFetcher.
@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Apr 7, 2020
@natalieparellano
Copy link
Member Author

Note the desired definitions for current and previous:

previous pack: latest released pack
current lifecycle: latest released lifecycle
previous lifecycle: latest patch of previous minor

@natalieparellano natalieparellano mentioned this issue Apr 7, 2020
Closed
@natalieparellano natalieparellano added status/ready Issue ready to be worked on. size/md Medium level of effort and removed status/triage Issue or PR that requires contributor attention. labels Apr 7, 2020
@natalieparellano
Copy link
Member Author

We decided to do this as part of #550.

@natalieparellano natalieparellano removed the status/ready Issue ready to be worked on. label Apr 8, 2020
@natalieparellano natalieparellano mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natalieparellano natalieparellano

Labels
size/md Medium level of effort type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natalieparellano