Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new --platform or --target flag to pack build command to avoid breaking M1 workflow users after multi-platform is released #2154

Closed
1 task
jjbustamante opened this issue May 14, 2024 · 1 comment · Fixed by #2162
Assignees
Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@jjbustamante
Copy link
Member

jjbustamante commented May 14, 2024

Description

Right now, multi-arch builders aren't too prevalent in the CNB ecosystem. Most builders are linux/amd64. But with the release of pack 0.34 (enables multi-arch builder creation) this might change.

Today, it is possible to specify the os/arch for a build by specifying the (not multi-arch) builder that supports the desired platform. When more builders are multi-arch, this selection mechanism goes away.

Specifically, M1 users with emulation enabled might lost the ability to build linux/amd64 images because when using a multi-arch builder, the linux/arm64 version will be automatically selected.

Proposed solution

We should support pack build --platform <my desired platform>

Describe alternatives you've considered

pack build --target <my desired platform> - but this probably makes sense to add when CNB supports cross-platform builds. As an example, pack build --platform <my desired build platform> --target <my desired runtime platform> could become a thing.

Additional context

  • This feature should be documented somewhere
@jjbustamante jjbustamante added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels May 14, 2024
@jjbustamante jjbustamante added this to the 0.34.0 milestone May 14, 2024
@jjbustamante
Copy link
Member Author

cc @natalieparellano

We need to fill the description.

@natalieparellano natalieparellano self-assigned this May 17, 2024
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels May 20, 2024
natalieparellano added a commit that referenced this issue May 20, 2024
Fixes #2154

Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano added a commit that referenced this issue May 20, 2024
Fixes #2154

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants