Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support docker:// URIs for builder lifecycle parameter #2076

Open
braunsonm opened this issue Feb 20, 2024 · 6 comments · May be fixed by #2112
Open

Support docker:// URIs for builder lifecycle parameter #2076

braunsonm opened this issue Feb 20, 2024 · 6 comments · May be fixed by #2112
Assignees
@rashadism
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.

Comments

@braunsonm
Copy link

braunsonm commented Feb 20, 2024 •
edited

Description

Right now we can provide a docker:// URI for the buildpacks listed in a builder inside the builder.toml but we cannot do the same thing with the lifecycle.

Proposed solution

[lifecycle]
  uri = "docker://buildpacksio/lifecycle:0.18.5"

Describe alternatives you've considered

Right now you need to provide a link to the tar.gz and cannot use docker images.

Additional context

The reason this would be a great quality of life feature is primarily because almost all the other fields in the specification allow docker:// archives. This would be consistent and not require a separate location for storage of the lifecycle binaries. It is a bit inconsistent that at build time you are able to specify a custom lifecycle image, but you can't do the same when you are packaging a builder.
@braunsonm braunsonm added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Feb 20, 2024
@braunsonm braunsonm changed the title Support docker:// URIs for lifecycle parameter Support docker:// URIs for builder lifecycle parameter Feb 20, 2024
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. good first issue A good first issue to get started with. and removed status/triage Issue or PR that requires contributor attention. labels Feb 21, 2024
@jjbustamante
Copy link
Member

  • The method responsible for fetching the lifecycle during builder creation is here
  • It seems safe to add the corresponding logic to process the new protocol type
  • On the other hand, the logic that handles docker:// when fetching buildpacks is here

@prashantrewar
Copy link

Hey @jjbustamante, I want to give it a try. Could you please assign this to me?

@rashadism
Copy link

Hi @jjbustamante , I would like to take a look if this is available

@natalieparellano
Copy link
Member

@prashantrewar were you still working on this one, or could @rashadism have it?

@prashantrewar
Copy link

@natalieparellano, I apologize, I'm busy with something. @rashadism you can feel free to try it.

Thank you!

@prashantrewar prashantrewar removed their assignment Mar 27, 2024
@rashadism rashadism linked a pull request Apr 1, 2024 that will close this issue
Open
2 tasks
@rashadism
Copy link

@jjbustamante @natalieparellano Hi can u review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashadism rashadism

Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support docker uri for lifecycle rashadism/pack
5 participants
@jjbustamante @braunsonm @natalieparellano @prashantrewar @rashadism