Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history metadata to layers created by pack builder create #2052

Open
edmorley opened this issue Feb 5, 2024 · 1 comment
Open

Add history metadata to layers created by pack builder create #2052

edmorley opened this issue Feb 5, 2024 · 1 comment
Labels
good for mentorship A good issue for a mentorship project. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone
0.35.0

Comments

@edmorley
Copy link
Contributor

edmorley commented Feb 5, 2024 •
edited

Description

Currently builder images created using pack builder create have blank descriptions for each layer when the builder is inspected using docker history <builder_image_name>.

This also causes the Docker Hub web layer UI to be blank:
https://hub.docker.com/layers/heroku/builder/22/images/sha256-72a0f9629ffb8826afed1ec47991cf9802b640ad44afdda6fbc4a14037cc4e4b?context=repo

Compare this to the docker history shown for an app image created by pack build, which includes descriptions for each layer - thanks to buildpacks/lifecycle#1099 and buildpacks/imgutil#202.

Proposed solution

To add history metadata for each layer in the builder image.

For example, each buildpack layer would be named after the buildpack ID and version.

For ideas on naming/style, see the descriptions used for the app image here:
https://github.com/buildpacks/lifecycle/blob/751c7a2737be2e6a8f66bfcc2e0cf0058661d6ff/acceptance/exporter_test.go#L104-L109
@edmorley edmorley added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Feb 5, 2024
@edmorley edmorley mentioned this issue Feb 5, 2024
Closed
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Feb 6, 2024
@jjbustamante jjbustamante added this to the 0.34.0 milestone Feb 6, 2024
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Mar 8, 2024
@edmorley
Copy link
Contributor Author

Example of how this currently shows up on Docker Hub:

docker-hub-builder-layers

@natalieparellano natalieparellano added help wanted Need some extra hands to get this done. good for mentorship A good issue for a mentorship project. labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for mentorship A good issue for a mentorship project. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.35.0
Development

No branches or pull requests
3 participants
@edmorley @jjbustamante @natalieparellano