Adds a convenience method for getting the build, launch and layer BOM file paths #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
type:enhancement
5 tasks
samj1912
requested changes
Nov 16, 2021
samj1912
reviewed
Nov 16, 2021
samj1912
reviewed
Nov 17, 2021
|
@samj1912 - Do you want me to squash all the commits? Or will you do that on merge? |
|
Squash would be nice! As a project we try to avoid changing commits from the authors and use "merge" instead. |
|
👍 @samj1912 - squashed. |
samj1912
requested changes
Nov 17, 2021
All set. |
samj1912
approved these changes
Nov 17, 2021
… file paths This PR includes: - convenience methods on the Layers and Layer object for fetching the SBoM path - deprecated messages if using old-style BOM functionality Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
|
Thanks for the PR! |
c0d1ngm0nk3y
pushed a commit
to sap-contributions/libcnb
that referenced
this pull request
Apr 28, 2023
Buildpacks API 0.7 brings one new feature, the functionality for SBoM output through [RFC buildpacks#95](https://github.com/buildpacks/rfcs/blob/main/text/0095-sbom.md). Without this change, you can write the SBoM information as described in RFC buildpacks#95, but the lifecycle will ignore it. To make the lifecycle capture your SBoM information you need to: 1. Use a version of libcnb with this PR. 2. Update the `api = "0.8"` line in your buildpack.toml. 3. Write the SBoM files from your buildpack according to the locations in RFC buildpacks#95. Libcnb does not provide any help with this activity presently, it is up to the buildpack author. 4. Use a lifecycle version with support, 0.13.0+ 5. Use a pack version with platform API 0.8+ The lifecycle should then copy your SBoM files and include them into the image. This PR is only required because the current implementation restricts usage of libcnb to specific buildpack API versions and we needed to add 0.7 to this list. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
Deprecated:godoc comments.