Skip to content
This repository has been archived by the owner on Jun 17, 2019. It is now read-only.

Evaluate eslint-plugin-compat #97

Open
gabro opened this issue Jan 3, 2017 · 6 comments
Open

Evaluate eslint-plugin-compat #97

gabro opened this issue Jan 3, 2017 · 6 comments

Comments

@gabro
Copy link
Member

gabro commented Jan 3, 2017

See https://github.com/amilajack/eslint-plugin-compat

@gabro
Copy link
Member Author

gabro commented Jan 14, 2017

Linto report

repo errors warnings
buildo/aliniq 0 0
buildo/web-shared 0 0
buildo/react-components 0 0
buildo/ipercron 0 0
buildo/avenger 3 0
buildo/bobafett 0 0
buildo/formo 0 0
buildo/hophop 0 0
buildo/pledge 0 0

The errors in avenger are about the use of fetch, which is not supported on Edge 13 and Safari 9.

@giogonzo
Copy link
Member

No it is not using fetch, I think it's a false positive

@FrancescoCioria
Copy link
Contributor

No it is not using fetch, I think it's a false positive

I remember it did, did you change it? I remember having to add a polyfill for IE11 due to fetch

@gabro
Copy link
Member Author

gabro commented Jan 15, 2017

If you run linto it now returns the snippet of where it's used and it did with Avenger. I'll double check

@giogonzo
Copy link
Member

@gabro can't run it now from mobile; I think it's a false positive because the keyword fetch indeed appears multiple times in src, but not accessing the global fetch api https://github.com/buildo/avenger/search?utf8=%E2%9C%93&q=fetch

@FrancescoCioria common misconception, avenger lib itself is not interested in http or using any xhr api/library. If someone was requiring fetch, it must have been the project in e.g. api.js

@gabro
Copy link
Member Author

gabro commented Jan 15, 2017

Oh, yes then it probably matches the keyword, and it's a false positive. I'll try soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants