rule proposal: promise plugin

[gabro]

Essentially this: https://github.com/xjamundx/eslint-plugin-promise

Thoughts? @buildo/frontend

[FrancescoCioria]

Interesting! I don't have (yet?) an opinion about each rule/case, but in general I have the feeling that some of them would be useful immediately.

If more people find this promising I think we should test each rule and report here the current amount of "errors" we have in QIA/AlinIQ

[gabro]

👍 ok for me, wanna list the ones you would include?

[ascariandrea]

As most of the time those rules are already shared, but not enforced, so my personal list would be

Simple and efficient

"promise/always-return": 2

Never saw in our code, anyway enforce it could be helpful

"promise/no-return-wrap": 2,

Not really useful (should we check param names for all lambdas we have)?

"promise/param-names": 0,

I ofter personally omit the catch part of a promise cause I'm confident errors will never happen 🙈

"promise/catch-or-return": 2

"In an ES5 environment, ..." we (buildo) are never in an "ES5 environment" nowadays

"promise/no-native": 0,

[giogonzo]

Not really useful (should we check param names for all lambdas we have)?

no but this one is a very special one ( a "revealing constructor" one https://blog.domenic.me/the-revealing-constructor-pattern/ , lol btw :P )

so I'm in favor of keeping the resolve and reject names consistent

[gabro]

What @ascariandrea proposes is all 👍 for me, with the exception of param-names for which I agree with @giogonzo

[giogonzo]

(keeping param-names I think we end up in the default setting for this rule)

[ascariandrea]

Do we agree in adding this with default settings?

[gabro]

Full force ahead! ✌️ But please make sure to fix projects before merging