forked from eslint/eslint
/
require-atomic-updates.js
277 lines (259 loc) · 8.8 KB
/
require-atomic-updates.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
/**
* @fileoverview disallow assignments that can lead to race conditions due to usage of `await` or `yield`
* @author Teddy Katz
*/
"use strict";
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require("../../../lib/rules/require-atomic-updates");
const { RuleTester } = require("../../../lib/rule-tester");
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
const VARIABLE_ERROR = {
messageId: "nonAtomicUpdate",
data: { value: "foo" },
type: "AssignmentExpression"
};
const STATIC_PROPERTY_ERROR = {
messageId: "nonAtomicUpdate",
data: { value: "foo.bar" },
type: "AssignmentExpression"
};
const COMPUTED_PROPERTY_ERROR = {
messageId: "nonAtomicUpdate",
data: { value: "foo[bar].baz" },
type: "AssignmentExpression"
};
ruleTester.run("require-atomic-updates", rule, {
valid: [
"let foo; async function x() { foo += bar; }",
"let foo; async function x() { foo = foo + bar; }",
"let foo; async function x() { foo = await bar + foo; }",
"async function x() { let foo; foo += await bar; }",
"let foo; async function x() { foo = (await result)(foo); }",
"let foo; async function x() { foo = bar(await something, foo) }",
"function* x() { let foo; foo += yield bar; }",
"const foo = {}; async function x() { foo.bar = await baz; }",
"const foo = []; async function x() { foo[x] += 1; }",
"let foo; function* x() { foo = bar + foo; }",
"async function x() { let foo; bar(() => baz += 1); foo += await amount; }",
"let foo; async function x() { foo = condition ? foo : await bar; }",
"async function x() { let foo; bar(() => { let foo; blah(foo); }); foo += await result; }",
"let foo; async function x() { foo = foo + 1; await bar; }",
/*
* Ensure rule doesn't take exponential time in the number of branches
* (see https://github.com/eslint/eslint/issues/10893)
*/
`
async function foo() {
if (1);
if (2);
if (3);
if (4);
if (5);
if (6);
if (7);
if (8);
if (9);
if (10);
if (11);
if (12);
if (13);
if (14);
if (15);
if (16);
if (17);
if (18);
if (19);
if (20);
}
`,
`
async function foo() {
return [
1 ? a : b,
2 ? a : b,
3 ? a : b,
4 ? a : b,
5 ? a : b,
6 ? a : b,
7 ? a : b,
8 ? a : b,
9 ? a : b,
10 ? a : b,
11 ? a : b,
12 ? a : b,
13 ? a : b,
14 ? a : b,
15 ? a : b,
16 ? a : b,
17 ? a : b,
18 ? a : b,
19 ? a : b,
20 ? a : b
];
}
`,
// https://github.com/eslint/eslint/issues/11194
`
async function f() {
let records
records = await a.records
g(() => { records })
}
`,
// https://github.com/eslint/eslint/issues/11687
`
async function f() {
try {
this.foo = doSomething();
} catch (e) {
this.foo = null;
await doElse();
}
}
`,
// https://github.com/eslint/eslint/issues/11723
`
async function f(foo) {
let bar = await get(foo.id);
bar.prop = foo.prop;
}
`,
`
async function f(foo) {
let bar = await get(foo.id);
foo = bar.prop;
}
`,
`
async function f() {
let foo = {}
let bar = await get(foo.id);
foo.prop = bar.prop;
}
`,
// https://github.com/eslint/eslint/issues/11954
`
let count = 0
let queue = []
async function A(...args) {
count += 1
await new Promise(resolve=>resolve())
count -= 1
return
}
`
],
invalid: [
{
code: "let foo; async function x() { foo += await amount; }",
errors: [{ messageId: "nonAtomicUpdate", data: { value: "foo" } }]
},
{
code: "if (1); let foo; async function x() { foo += await amount; }",
errors: [{ messageId: "nonAtomicUpdate", data: { value: "foo" } }]
},
{
code: "let foo; async function x() { while (condition) { foo += await amount; } }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = foo + await amount; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = foo + (bar ? baz : await amount); }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = foo + (bar ? await amount : baz); }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = condition ? foo + await amount : somethingElse; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = (condition ? foo : await bar) + await bar; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo += bar + await amount; }",
errors: [VARIABLE_ERROR]
},
{
code: "async function x() { let foo; bar(() => foo); foo += await amount; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; function* x() { foo += yield baz }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = bar(foo, await something) }",
errors: [VARIABLE_ERROR]
},
{
code: "const foo = {}; async function x() { foo.bar += await baz }",
errors: [STATIC_PROPERTY_ERROR]
},
{
code: "const foo = []; async function x() { foo[bar].baz += await result; }",
errors: [COMPUTED_PROPERTY_ERROR]
},
{
code: "let foo; async function* x() { foo = (yield foo) + await bar; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = foo + await result(foo); }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = await result(foo, await somethingElse); }",
errors: [VARIABLE_ERROR]
},
{
code: "function* x() { let foo; yield async function y() { foo += await bar; } }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function* x() { foo = await foo + (yield bar); }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo; async function x() { foo = bar + await foo; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo = {}; async function x() { foo[bar].baz = await (foo.bar += await foo[bar].baz) }",
errors: [COMPUTED_PROPERTY_ERROR, STATIC_PROPERTY_ERROR]
},
{
code: "async function x() { foo += await bar; }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo = 0; async function x() { foo = (a ? b : foo) + await bar; if (baz); }",
errors: [VARIABLE_ERROR]
},
{
code: "let foo = 0; async function x() { foo = (a ? b ? c ? d ? foo : e : f : g : h) + await bar; if (baz); }",
errors: [VARIABLE_ERROR]
},
// https://github.com/eslint/eslint/issues/11723
{
code: `
async function f(foo) {
let buz = await get(foo.id);
foo.bar = buz.bar;
}
`,
errors: [STATIC_PROPERTY_ERROR]
}
]
});