Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: What this PR does
Per #56, EachKey cannot handle a variety of cases where there are more than 64 keys, or 64 elements in an array we're extracting. This fixes that.
Note that the PR template's command for running benchmarks (
go test -test.benchmem -bench JsonParser ./benchmark/ -benchtime 5s -v
) doesn't work, so I instead added a replace directive in the benchmark/ directory's go.mod to point at my checked-out repository, then rango test -bench .
against the master branch, then against my branch.Benchmark before change:
Benchmark after change: