fix regression in plugin generation #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Remote' field contains the full plugin name (including path and version information). For the GetRemoteHostname() method, we should parse the hostname portion and return it. This resolves 404 errors when generating with older plugins.
pkwarren
requested review from
unmultimedio,
srikrsna-buf,
a team and
twilly
unmultimedio
approved these changes
Dec 12, 2022
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
The 'Remote' field contains the full plugin name (including path and version information). For the GetRemoteHostname() method, we should parse the hostname portion and return it. This resolves 404 errors when generating with older plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Remote' field contains the full plugin name (including path and version information). For the GetRemoteHostname() method, we should parse the hostname portion and return it.
This resolves 404 errors when generating with older plugins.