Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user type filter for ListUsers and include user type in User #1660

Merged
merged 2 commits into from Dec 12, 2022
Merged

add user type filter for ListUsers and include user type in User #1660

merged 2 commits into from Dec 12, 2022

Conversation

cyinma
Copy link
Member

@cyinma cyinma commented Dec 8, 2022

fixes BSR-959

@cyinma cyinma requested review from a team, njhale and unmultimedio December 8, 2022 22:00
@cyinma cyinma changed the title add user type filter for ListUsers add user type filter for ListUsers and include user type in User Dec 9, 2022
njhale
njhale approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyinma cyinma merged commit e85a0a6 into main Dec 12, 2022
@cyinma cyinma deleted the cyinma/add-type-filter-for-list-user branch December 12, 2022 20:29
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
@cyinma
add user type filter for ListUsers and include user type in User (buf…
6f4eb7e 
…build#1660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@unmultimedio unmultimedio Awaiting requested review from unmultimedio unmultimedio was automatically assigned from bufbuild/bsr-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyinma @njhale