Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy agent #75

Merged
merged 2 commits into from Nov 28, 2022
Merged

Add proxy agent #75

merged 2 commits into from Nov 28, 2022

Conversation

sjdaws
Copy link
Contributor

@sjdaws sjdaws commented Nov 24, 2022

Support the use of http_proxy when looking up releases via GitHub URL.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

elliotmjackson
elliotmjackson approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@elliotmjackson elliotmjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sjdaws

@sjdaws
Copy link
Contributor Author

sjdaws commented Nov 24, 2022

Sorry @elliotmjackson this had our npm proxy registry in the lock file so it failed CI, I've updated it to use the node registry

@elliotmjackson elliotmjackson merged commit ffdd84c into bufbuild:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotmjackson elliotmjackson elliotmjackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjdaws @CLAassistant @elliotmjackson