Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker + FA6 is broken #3675

Closed
rluisr opened this issue Feb 20, 2022 · 4 comments
Closed

DateTimePicker + FA6 is broken #3675

rluisr opened this issue Feb 20, 2022 · 4 comments
Labels

Comments

@rluisr
Copy link

rluisr commented Feb 20, 2022

Overview of the problem

Buefy version: 0.9.16
Vuejs version: 2.6.14
OS/Browser: 98.0.4758.102

Description

An icon sticks out from input after upgrade font awesome 6 and buefy v0.9.16.
Before the upgrade, no issue was found.

Steps to reproduce

<b-field>
  <b-datetimepicker
    icon="calendar-plus"
    icon-pack="fas"
  />
</b-field>

Expected behavior

Fit with input like this.

スクリーンショット 2022-02-21 3 13 09

Actual behavior

スクリーンショット 2022-02-21 3 00 57

I tried to implement it on CodePen to make things easier for you, but I couldn't find a CDN for fontawesome-svg-core.

@rluisr rluisr changed the title DateTimePicker + icon with FA6 is broken DateTimePicker + FA6 is broken Feb 20, 2022
@jtommy
Copy link
Member

jtommy commented Feb 20, 2022

I added only the new icon packs but maybe I understand the problem..

@sgarner
Copy link
Contributor

sgarner commented Feb 24, 2022

The sizing of icons is affected in many places with FA6 + Buefy, and not specific to DateTimePicker.

See also #3668 (comment)

@erenbertr
Copy link

For now I "solved" this issue with:

.icon svg { width: 1em; height: 1em; max-width: 80%; max-height: 80%; }

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@stale stale bot closed this as completed Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants