Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad detection doesn't work anymore #3342

Closed
lboecker opened this issue May 25, 2021 · 3 comments · Fixed by #3343
Closed

iPad detection doesn't work anymore #3342

lboecker opened this issue May 25, 2021 · 3 comments · Fixed by #3343

Comments

@lboecker
Copy link
Contributor

Apple changed the user agent for the iPad a while ago which breaks the iOS detection code in src/utils/helpers.js.

@jtommy
Copy link
Member

jtommy commented May 25, 2021

@lboecker can you make a PR ?

@lboecker
Copy link
Contributor Author

@jtommy I'm not sure what to do about that. Right now it seems people are testing if navigator.platform is "MacIntel" and if the device also supports touch. That obviously only works until Apple releases a touch-screen MacBook or something like that.

Here is one example that works like that (they all look pretty much the same): https://stackoverflow.com/a/58064481

Do you want me to add that to the iOS detection code?

@jtommy
Copy link
Member

jtommy commented May 25, 2021

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants