New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing of a datetimeCreator prop to the DatetimePicker component #2000
Comments
@jtommy Thanks a lot for the quick response! Actually, after looking a bit more, I think more code would need to be changed: in order to be able to support a different timezone, we would need to be able to use the custom creator with existing values as well (lines 46 and 286 of |
Hello again… After looking closer at the code, I believe it would make more sense to support timezones by providing a Code changes would be something like:
In order to properly handle other props such as What do you think? If that seems like the right track, I'll be happy to provide a pull request. |
As described in #1083, there is a
dateCreator
prop available to change the Date creator on theDatePicker
component (and for example, allow to set a timezone different from the user locale).It would be great if the same prop was available for
DatetimePicker
(and maybe evenTimePicker
?). At the moment, there seems to be an (undocumented)DatetimeCreator
prop, but I don't think it behaves as expected (it never seems to get called when using the component with a set value).The text was updated successfully, but these errors were encountered: