Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tab keycode to confirmKeyCodes in Taginput.vue #1065

Merged
merged 1 commit into from Nov 12, 2018
Merged

Added tab keycode to confirmKeyCodes in Taginput.vue #1065

merged 1 commit into from Nov 12, 2018

Conversation

wrabit
Copy link
Contributor

@wrabit wrabit commented Nov 5, 2018

I think this resolves the issue. #973

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #1065 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1065   +/-   ##
====================================
  Coverage    43%     43%           
====================================
  Files        41      41           
  Lines      1293    1293           
  Branches    394     394           
====================================
  Hits        556     556           
  Misses      719     719           
  Partials     18      18
Impacted Files Coverage Δ
src/components/taginput/Taginput.vue 26.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98f16f...c959cf1. Read the comment docs.

@jtommy
Copy link
Member

jtommy commented Nov 5, 2018

@williamabbott What issue has been fixed ?

@wrabit
Copy link
Contributor Author

wrabit commented Nov 5, 2018

See referenced issue.. Taginput on mobile doesnt add the tag. When in android for example the only confirm button you get on the keyboard actually tabs to the next field instead of entering. I added tab keycode.

@wrabit
Copy link
Contributor Author

wrabit commented Nov 5, 2018

(when 'add new' is active)

@jtommy jtommy merged commit 3da84e5 into buefy:dev Nov 12, 2018
@tycrimm
Copy link

tycrimm commented Feb 26, 2019

This breaks the ability to tab from a TagInput to another form component for the sake of the mobile fix. Reverting the PR allows the user to once again tab between input components on a desktop. Can we find a better workaround for mobile so we don't break the desktop experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants