Unit Tests: upgrade vue-test-utils to latest version, correct deprecation warning #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade the version of vue-test-utils to the latest one (which include proper support for scopedSlot testing) and to remove all the warning generated by the now deprecated function
shallow
There is only one touch to the the actual code in the dialog component
beforeMount
hook, where I wrapped the appendChild in a next tick function.The code was working even without the
nextTick
( in the browser ) but only because of timing but it was not passing in the tests ( and is conceptually wrong: https://vuejs.org/v2/api/#beforeMount since in beforeMount the render function is not yet called $el can't be present yet. )see this fiddle for a better example: https://jsfiddle.net/0n5fmch3/
stringifying
this.$el
show empty object, while inside thenextTick
the element exist ( is not possible to stringify it when is a real dom since is a circular structure )Hope this helps!