Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipFonts is not used to control the download of fonts #93

Closed
karthik-srinivas opened this issue Feb 11, 2021 · 5 comments
Closed

skipFonts is not used to control the download of fonts #93

karthik-srinivas opened this issue Feb 11, 2021 · 5 comments

Comments

@karthik-srinivas
Copy link

karthik-srinivas commented Feb 11, 2021

Problem

I am trying to convert DOM to image (PNG,JPEG,SVG), I see lots of requests for google fonts are made, you can see in the below image

image

I have provided the skipFonts property in options object, this would not help

image

skipFonts property is not used anywhere in the code, could you please update on this, Thank you

@vivcat
Copy link
Contributor

vivcat bot commented Feb 11, 2021

👋 @karthik-srinivas

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@vivcat
Copy link
Contributor

vivcat bot commented Mar 4, 2021

Hiya!
This issue has gone quiet. Spooky quiet. 👻
We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

Thanks for being a part of the Antv community! 💪💯

@vivcat vivcat bot added the stale label Mar 4, 2021
@vivcat
Copy link
Contributor

vivcat bot commented Apr 14, 2021

Hey again!
It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.
Thanks again for being part of the Antv community! 💪💯

@vivcat vivcat bot closed this as completed Apr 14, 2021
@JGJP
Copy link

JGJP commented Jul 28, 2021

Using this bot to close valid issues like this is so bad..

If you want a temporary workaround for skipping fonts, you can apply this patch with patch-package:

diff --git a/node_modules/html-to-image/es/index.js b/node_modules/html-to-image/es/index.js
index 5b0673d..85f9794 100644
--- a/node_modules/html-to-image/es/index.js
+++ b/node_modules/html-to-image/es/index.js
@@ -22,7 +22,6 @@ export function toSvg(domNode, options = {}) {
     return __awaiter(this, void 0, void 0, function* () {
         const { width, height } = getImageSize(domNode, options);
         return cloneNode(domNode, options, true)
-            .then((clonedNode) => embedWebFonts(clonedNode, options))
             .then((clonedNode) => embedImages(clonedNode, options))
             .then((clonedNode) => applyStyleWithOptions(clonedNode, options))
             .then((clonedNode) => createSvgDataURL(clonedNode, width, height));

@vivcat
Copy link
Contributor

vivcat bot commented Jul 29, 2022

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@vivcat vivcat bot locked as resolved and limited conversation to collaborators Jul 29, 2022
bubkoo added a commit that referenced this issue Aug 26, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants