Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: filter method #328

Merged
merged 1 commit into from Dec 3, 2022
Merged

docs: filter method #328

merged 1 commit into from Dec 3, 2022

Conversation

happy-func
Copy link
Contributor

@happy-func happy-func commented Nov 4, 2022

subject: doc filter method working error

modified: README.md

Description

node.classList.includes(classname) // Property 'includes' does not exist on type 'DOMTokenList'

&& classList may be null

Motivation and Context

impove lib experience

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

subject: doc filter method working error

modified:   README.md
@vivcat
Copy link
Contributor

vivcat bot commented Nov 4, 2022

👋 @happy-func

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@vivcat vivcat bot added the PR: unreviewed label Nov 4, 2022
@bubkoo bubkoo merged commit edaa63b into bubkoo:master Dec 3, 2022
@vivcat
Copy link
Contributor

vivcat bot commented Dec 3, 2022

👋 @happy-func Congrats on merging your first pull request! 🎉🎉🎉

@vivcat vivcat bot added PR: merged and removed PR: unreviewed labels Dec 3, 2022
@vivcat
Copy link
Contributor

vivcat bot commented Dec 3, 2022

🎉 This PR is included in version 1.10.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vivcat vivcat bot added the released label Dec 3, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
subject: doc filter method working error

modified:   README.md
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
subject: doc filter method working error

modified:   README.md
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
subject: doc filter method working error

modified:   README.md
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
subject: doc filter method working error

modified:   README.md
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
subject: doc filter method working error

modified:   README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants