Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari images #325

Merged
merged 1 commit into from Dec 3, 2022
Merged

Fix Safari images #325

merged 1 commit into from Dec 3, 2022

Conversation

merapi
Copy link
Contributor

@merapi merapi commented Oct 12, 2022

Description

We have found & fix this issue in Safari: GoogleForCreators/web-stories-wp#12432

decode() support is great so we probably don't need a fallback, but I'm happy to hear your thoughts.

Also, I think the readme should be updated because it works pretty well in Safari.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 67.05% // Head: 67.05% // No change to project coverage 👍

Coverage data is based on head (8a51ae5) compared to base (471ad8d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          10       10           
  Lines         513      513           
  Branches      119      119           
=======================================
  Hits          344      344           
  Misses        120      120           
  Partials       49       49           
Impacted Files Coverage Δ
src/embed-images.ts 96.66% <100.00%> (ø)
src/util.ts 63.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bubkoo bubkoo merged commit 759a7a1 into bubkoo:master Dec 3, 2022
@vivcat vivcat bot added PR: merged and removed PR: unreviewed labels Dec 3, 2022
@vivcat
Copy link
Contributor

vivcat bot commented Dec 3, 2022

🎉 This PR is included in version 1.10.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vivcat vivcat bot added the released label Dec 3, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants