rpcclient: Add retry with backoffs to HTTP POST requests #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nprob
changed the title
3nprob
force-pushed
the
http-retries
branch
2 times, most recently
from
5b22bc9
to
af15cee
Compare
This was referenced Aug 25, 2021
Pull Request Test Coverage Report for Build 1458619518
💛 - Coveralls |
Adds behavior similar to the retries of persistent RPC connections to HTTP request. * Initial backoff: 500ms * Linear increase * Max retries: 10 Room for future improvement: * Make configurable * Add jitter * Tests for retry behavior
|
@jcvernaleo @Roasbeef Just rebased on master and resolved the conflicts. Any chance this will be looked at anytime soon ? Have been running with this for lnd for some time with significant improvement in reliability |
|
@3nprob I made the actions run and I made a note to review this on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: When used as a library in LND, current behavior means that a
single request failing will result in the entire process shutting down.
This adds behavior similar to the retries of persistent RPC connections
to HTTP request.
Room for future improvement:
Unfortunately due to the way Go http requests are consumed, I had to move down the construction of the request. This resulted in
sendPostDetailsandsendPostbecoming redundant.