Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson: Update WalletCreateFundedPsbtOpts.FeeRate type #1729

Merged
merged 1 commit into from Jun 25, 2021
Merged

btcjson: Update WalletCreateFundedPsbtOpts.FeeRate type #1729

merged 1 commit into from Jun 25, 2021

Conversation

gnasr
Copy link
Contributor

@gnasr gnasr commented Jun 25, 2021

FeeRate is expressed in BTC/kb so the correct type is *float64

Fixes #1728
This is my first PR. Any feedback is appreciated

onyb
onyb approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats on your first PR!

@coveralls
Copy link

coveralls commented Jun 25, 2021 •
edited

Pull Request Test Coverage Report for Build 972334220

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 52.909%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 5 75.95%
Totals Coverage Status
Change from base Build 896856960: 0.01%
Covered Lines: 21022
Relevant Lines: 39732
💛 - Coveralls

@onyb onyb merged commit 86a1726 into btcsuite:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

btcjson: FeeRate in WalletCreateFundedPsbtOpts has wrong type
3 participants
@gnasr @coveralls @onyb