New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative paths #2
Comments
Thanks for the heads up, you can always open a PR with WIP in the title and we can discuss. In the meantime I will look at your branch and think about it. |
Just looked at your patch, I will merge it if you submit a PR. |
My branch is definitely not ready. It solves my own case (having a path
like “../../.env”) but it doesn’t take into account others. We also have to
factor in whether this breaks other Babel plugins.
…--
Best Regards,
Adrian Perez
https://adrianperez.codes
On September 10, 2017 at 5:18:11 PM, Bryan Goldstein ( ***@***.***) wrote:
Just looked at your patch, I will merge it if you submit a PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIIvDNAmTNlzEwNerreBQIQ64kHiWC1ks5sg_2zgaJpZM4PQgVY>
.
|
Not sure I understand the scenario you are thinking of. If I recall correctly, what you've done is check for |
No. That’s exactly what it does. I’m just worried it hasn’t gone through
enough testing to make it mergeable but maybe that’s just me ;)
…--
Best Regards,
Adrian Perez
https://adrianperez.codes
On September 11, 2017 at 3:17:34 PM, Bryan Goldstein ( ***@***.***) wrote:
Not sure I understand the scenario you are thinking of. If I recall
correctly, what you've done is check for .. in the path and resolve it
using the node API if it has dots. Did I miss read your solution?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIIvLrFvTMdPedG1ftSHZG1U3g3Exgxks5shTLugaJpZM4PQgVY>
.
|
You are right, I made some faulty assumptions about the adoption of this package. If you think it is a broader question of babel plugins, it may be worth asking @hzoo. |
@blackxored - I just added a test suite with a simple test, obviously it will need more test cases, but now at least it is there and running in CI. You made me realize this has wider adoption than I thought, so I am going to put a little effort into cleaning it up a bit. |
This seems to be a common issue with babel plugins, we're doing relative reads (or dotenv ends up doing relative read), so a path with something like '../../.env' (lerna setup, I know :() starts failing.
Solved in a fork but wondering how to handle or whether to relay upstream.
The text was updated successfully, but these errors were encountered: