Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPM (TTY-Mode) doesn't work #402

Closed
tobi2409 opened this issue Feb 25, 2022 · 21 comments
Closed

GPM (TTY-Mode) doesn't work #402

tobi2409 opened this issue Feb 25, 2022 · 21 comments
Labels

Comments

@tobi2409
Copy link

It seems that it's not possible clicking HTML elements (buttons, textfields etc.) with GPM-Mouse in TTY-Mode.

@tombh
Copy link
Member

tombh commented Feb 25, 2022

Browsh generally works with a mouse. So maybe it's a specific website, can you give an example URL where it happens?

@tobi2409
Copy link
Author

I tried it with Google, Amazon and Youtube. In KDE-Konsole I can work with mouse but in TTY-Mode and enabled GPM it's not possible.

@tombh
Copy link
Member

tombh commented Feb 25, 2022

So Google works with the mouse in KDE's Konsole app? I don't understand why GPM is relevant here?

@tobi2409
Copy link
Author

Because I want to use Browsh also without X-Server. (in pure Console-mode)

@tombh tombh added the bug label Feb 25, 2022
@tombh
Copy link
Member

tombh commented Feb 25, 2022

Ohh GPM is a way of using the mouse without X11? I didn't know that. Yes I totally agree that Browsh should work in a pure console environment. So I'll mark this as a bug. Thank you

@tobi2409
Copy link
Author

Ohh GPM is a way of using the mouse without X11? Yes. Thank you :)

@tobi2409
Copy link
Author

Thank you :) And when we can plan with the bugfix? Because the latest version (1.64) is from 2019.

@tombh
Copy link
Member

tombh commented Feb 26, 2022

The reality is that I neither need to find a way of making a living from Browsh or I need to save up enough money to be able to have the months I need to work on Browsh again. I would love to find a way, but it's not going to happen any time soon I'm afraid 😕

@00c0
Copy link

00c0 commented Mar 13, 2022

How can I implement it?

@tombh
Copy link
Member

tombh commented Mar 13, 2022

First thing would be to set some debugging here to see if Browsh is even receiving events from GPM. Linux build instructions are here: https://github.com/browsh-org/browsh/blob/master/contrib/setup_linux_build_environment.md

@00c0
Copy link

00c0 commented Mar 14, 2022

Browsh isn't receiving events from GPM.

@tombh
Copy link
Member

tombh commented Mar 14, 2022

Can you outline the steps you took to reproduce that?

@00c0
Copy link

00c0 commented Mar 14, 2022

I went into tty. I enabled the GPM service. I ran browsh with the --debug flag. I tried to click on links. I closed browsh. I looked at the log file.

@tombh
Copy link
Member

tombh commented Mar 14, 2022

You didn't follow my instructions in the comment above: #402 (comment)

@00c0
Copy link

00c0 commented Mar 14, 2022

I'm sorry. I don't understand. Please may you explain.

@tombh
Copy link
Member

tombh commented Mar 14, 2022

What don't you understand? Where the comment is? How to add code to Golang? How to build Browsh? You will need to experiment for yourself and let me know at what point you're unable to proceed any further.

@00c0
Copy link

00c0 commented Mar 15, 2022

I built browsh. I was able to use it in terminal on top of X. I was able to launch it in tty. I am unable to click in tty.

@tombh
Copy link
Member

tombh commented Mar 15, 2022

Were you able to add a logging line here? https://github.com/browsh-org/browsh/blob/master/interfacer/src/browsh/tty.go#L173 If so, what is the logging line?

@00c0
Copy link

00c0 commented Mar 15, 2022

I was able to add a logging line there. The logging line isLog("mouseEvent").

@tombh
Copy link
Member

tombh commented Mar 15, 2022

Thanks, that's great. It led me to realise that it's a tcell issue. There's actually already an issue about it there! gdamore/tcell#297 So you can discuss there if you'd like to implement the solution.

@tombh
Copy link
Member

tombh commented Mar 15, 2022

So I'm going to close this issue as it is a duplicate of #237

@tombh tombh closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants