Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fails incorrectly with Mocha 8 and later #248

Open
Krinkle opened this issue Jun 6, 2021 · 0 comments · May be fixed by #249
Open

Test fails incorrectly with Mocha 8 and later #248

Krinkle opened this issue Jun 6, 2021 · 0 comments · May be fixed by #249

Comments

@Krinkle
Copy link
Contributor

Krinkle commented Jun 6, 2021

See also js-reporters/js-reporters#116. The issue has been fixed in js-reporters 2.0.
Krinkle added a commit to qunitjs/browserstack-runner that referenced this issue Jun 6, 2021
@Krinkle
Update js-reporters to 2.1.0
8d262e3 
Important changes:

* Mocha 8 and later are now supported. Previously, it's pending tests
  were incorrectly reported as undefined or failing.

* `QUnit.todo()` is now supported. Previously, these intentional
  failures were reported by browserstack-runner as failing tests.

  With js-reported 2.1 the runEnd report counts them as `todo` instead
  of as `failed`.

The API that browserstack-runner depends on has not changed since 1.1.0.
<https://github.com/js-reporters/js-reporters/blob/v2.1.0/CHANGELOG.md>.

Specifically, browserstack-runner captures the following data in
lib/_patch/reporter.js, and proccesses it in lib/server.js under
the "_progress" and "_report" handlers:

* The `testEnd` event, reading:
  - `name` string,
  - `suiteName` string,
  - `status` string,
  - `errors` array.

* The `runEnd` event, reading:
  - `status` string,
  - `testCounts` object with ints `total`, `passed`, `failed`, `skipped`,
  - `runtime` int.

These still exist the same way in the latest release:
<https://github.com/js-reporters/js-reporters/blob/v2.1.0/spec/cri-draft.adoc#runend>

Fixes browserstack#248.
Ref browserstack#247.
@Krinkle Krinkle linked a pull request Jun 6, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to js-reporters 2 qunitjs/browserstack-runner
1 participant
@Krinkle