New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error on missing environment #560
base: main
Are you sure you want to change the base?
Conversation
What if add an option about generate or not error in this case? |
Thanks for taking a look at this PR, @Semigradsky! I'm not sure I follow your suggestion, however. The idea is to only enable this in Adding an option seems to me like a bad idea, because it could lead to different Perhaps I'm misunderstanding your suggestion? |
Don't worry, this is just my suggestion on how to release it in the near future) |
@Semigradsky anyway we need major release for other features |
|
|
This PR introduces a check for missing environment configuration when explicitly providing an environment name, either by including it in
opts
or by providing it via theBROWSERSLIST_ENV
environment variable.It now throws an explicit error, whereas before it silently used the config defaults.
As discussed in #559, this is a breaking change.
Fixes #559.